RFR: 8282526: Default icon is not painted properly [v3]

Wed Apr 27 00:03:45 UTC 2022

On Tue, 26 Apr 2022 23:22:18 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> We are setting the BICUBIC only in place where we draw the image part of ImageIcon. There is no benefit in pushing this change down the pipeline.

We don't need to push change down to the pipeline, we should push it up to the place where we paint this ImageIcon, eventually where we call ImageIcon.paintIcon()

> It is not a regression, it is a side effect of the JDK-8182043 combined with the Windows 10 update that changed the default windows file icon to the blank white sheet with 1 pixel wide dark gray border.
> Because we can not read this icon from the native, when we ask Windows API to provide this icon it ignores the icon size and gives the same 32x32 icon instead. We knew this upfront and the consensus was that we will provide the icon in the MultiResolutionImage and scaling during painting will be good enough to scale it properly. But it is not.

Then why, as described in the JBS, it worked before? Did we request different image, or size, or did we skip scaling?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7805