RFR: 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class [v2]

Phil Race prr at openjdk.java.net
Wed Apr 27 18:46:06 UTC 2022


On Sun, 4 Apr 2021 07:58:44 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Initial version 8264666
>>  - Merge branch 'master' into LCMSImageLayout
>>  - Revert "safeXX -> xxExact"
>>    
>>    This reverts commit a1876fa596a6831f036c04f45fa89c2caba47087.
>>  - Revert "delete "do{...} while (false);""
>>    
>>    This reverts commit a9e91601c355f96c82dd8b2b8564a3a3e7b96aef.
>>  - delete "do{...} while (false);"
>>  - safeXX -> xxExact
>
> src/java.desktop/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java line 241:
> 
>> 239:                     l.dataType = DT_INT;
>> 240: 
>> 241:                     if (l.nextRowOffset == l.width * 4 * intRaster.getPixelStride()) {
> 
> Any idea why the "do/while(false)" was used here?

I can only guess it was just style ..

-------------

PR: https://git.openjdk.java.net/jdk/pull/3333



More information about the client-libs-dev mailing list