RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v2]

DamonGuy duke at openjdk.java.net
Wed Apr 27 18:52:46 UTC 2022


> The insets for buttons were incorrect for L&Fs except for Aqua when the text is set to HTML. This was fixed in Aqua by adding a conditional to check for the BasicHTML property key in the button component. This same logic can be used to fix Metal & Motif L&Fs in BasicButtonUI, but Nimbus is not fixed by this. Nimbus gets its default values from a skin.laf file, and when the defaults here are set to have left & right insets to 0 for ButtonUI, the issue is fixed. I also tested for non-HTML text after the changes, and the changes do not affect normal text.
> 
> The HtmlButtonImageTest has been changed to cycle through all L&Fs available on a device.

DamonGuy has updated the pull request incrementally with one additional commit since the last revision:

  Changed approach to fix.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8407/files
  - new: https://git.openjdk.java.net/jdk/pull/8407/files/50001b33..05bd9a42

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8407&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8407&range=00-01

  Stats: 32 lines in 2 files changed: 20 ins; 3 del; 9 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8407/head:pull/8407

PR: https://git.openjdk.java.net/jdk/pull/8407



More information about the client-libs-dev mailing list