RFR: JDK-8285730: unify _WIN32_WINNT settings

Erik Joelsson erikj at openjdk.java.net
Thu Apr 28 12:36:42 UTC 2022


On Thu, 28 Apr 2022 07:16:30 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Hi Erik/David/Phil, we already have a good central place where we set the definition of WIN32_LEAN_AND_MEAN
> 
> autoconf/flags-cflags.m4:460: ALWAYS_DEFINES_JDK="-DWIN32_LEAN_AND_MEAN -D_CRT_SECURE_NO_DEPRECATE autoconf/flags-cflags.m4:462: ALWAYS_DEFINES_JVM="-DNOMINMAX -DWIN32_LEAN_AND_MEAN"
> 
> should we add there the _WIN32_WINNT=0x0601 define (and remove the differing defines instead at the other places) ? (defines of _WIN32_WINNT in 3rd party code would stay like wepoll.c and harfbuzz).

Seems reasonable to me at least.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8428



More information about the client-libs-dev mailing list