RFR: 8274597: Some of the dnd tests time out and fail intermittently [v2]

Manukumar V S mvs at openjdk.java.net
Thu Apr 28 22:21:38 UTC 2022


On Wed, 27 Apr 2022 18:11:39 GMT, Phil Race <prr at openjdk.org> wrote:

>> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added blank line at end of file
>
> test/jdk/java/awt/regtesthelpers/Util.java line 325:
> 
>> 323:             robot.setAutoDelay(100);
>> 324:             autoDelaySet = true;
>> 325:         }
> 
> If this is the right place to fix it - in the Util class - then you can just call delay(100) in the places you need it - no need to set and then unset auto-delay.
> 
> Changing Util you will need to re-validate all tests that use this utility method.
> 
> Based on the explanation you gave ~mrserb I wonder if the test should also be waiting for the drop before disposing, not just throwing an arbitrary wait into the mix.

I have removed the changes done in Util.java and make the changes in all the 4 test files, so that the test will be waiting for the drop before disposing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8316



More information about the client-libs-dev mailing list