RFR: 6521141: DebugGraphics NPE @ setFont(); [v7]

Andrey Turbanov aturbanov at openjdk.org
Wed Aug 3 06:18:57 UTC 2022


On Tue, 2 Aug 2022 06:51:36 GMT, Tejesh R <tr at openjdk.org> wrote:

>> `DebugGraphics` class has a Graphics instance which is been used in slowed down drawing. The `graphics` object is not initialized anywhere inside the class, where it is expected to set explicitly by the user. When the user doesn't set it and try to use the any mehtods like `drawing/setFont`, NPE is raised which is expected. The scenario is taken care by checking if the `graphics` object is null before using it inside the class, thus eliminating the NPE case.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated based on review comments

src/java.desktop/share/classes/javax/swing/DebugGraphics.java line 98:

> 96:             });
> 97: 
> 98:             if(walker.getCallerClass() != this.getClass()) {

Let's add space after `if`

-------------

PR: https://git.openjdk.org/jdk/pull/9673



More information about the client-libs-dev mailing list