RFR: 8281966: Absolute path of symlink is null in JFileChooser [v2]

[Tejesh R]

On Fri, 29 Jul 2022 18:07:40 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix : Updated to handle multiSelection case
>>  - Manual Test Indicator Added in JTREG tag
>
> test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java line 32:
> 
>> 30:             is valid on ValueChanged property listener.
>> 31:    @run main FileChooserSymLinkTest
>> 32: */
> 
> May I ask to place these tags before the class declaration?
> 
> Add the asterisk to each line, like you see in the copyright and other tests.

Updated.

> test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java line 45:
> 
>> 43: import javax.swing.WindowConstants;
>> 44: 
>> 45: public class FileChooserSymLinkTest{
> 
> Suggestion:
> 
> public class FileChooserSymLinkTest {

Updated.

> test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java line 76:
> 
>> 74:                 2. Create a Symbolic link targeting the created test directory.
>> 75:                     ex : mklink /D c:\\link c:\\target
>> 76:                 3. In JFileChooser, navigate to "link" created directed.
> 
> …navigate to directory where you created the link. In this example, to C:\ drive.
> 
> Please use the capital C: for the drive.

Updated.

-------------

PR: https://git.openjdk.org/jdk/pull/9597