RFR: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent [v3]
Sergey Bylokhov
serb at openjdk.org
Fri Aug 5 01:35:27 UTC 2022
> The specification of the ICC_ColorSpace.fromCIEXYZ method [says](https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/java/awt/color/ICC_ColorSpace.java#L428):
>
>> * This method transforms color values using relative colorimetry, as defined by the ICC Specification.
>
> The LCMS plugin implementation expects the rendering intent in the first part of transform:
> https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java#L116
>
> But the ICC_ColorSpace.fromCIEXYZ pass "ICC_Profile.icRelativeColorimetric" to the [second ](https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/java/awt/color/ICC_ColorSpace.java#L534) part of transform.
>
> Note that ICC_ColorSpace.toCIEXYZ has a similar [specification ](https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/java/awt/color/ICC_ColorSpace.java#L288)is implemented [properly](https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/java/awt/color/ICC_ColorSpace.java#L391).
Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
Update ToFromCIEXYZRoundTrip.java
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/9194/files
- new: https://git.openjdk.org/jdk/pull/9194/files/045e55bf..dbe791cd
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=9194&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=9194&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/9194.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9194/head:pull/9194
PR: https://git.openjdk.org/jdk/pull/9194
More information about the client-libs-dev
mailing list