RFR: 6521141: DebugGraphics NPE @ setFont(); [v8]

Prasanta Sadhukhan psadhukhan at openjdk.org
Fri Aug 5 10:54:50 UTC 2022


On Fri, 5 Aug 2022 09:32:05 GMT, Tejesh R <tr at openjdk.org> wrote:

>> `DebugGraphics` class has a Graphics instance which is been used in slowed down drawing. The `graphics` object is not initialized anywhere inside the class, where it is expected to set explicitly by the user. When the user doesn't set it and try to use the any mehtods like `drawing/setFont`, NPE is raised which is expected. The scenario is taken care by checking if the `graphics` object is null before using it inside the class, thus eliminating the NPE case.
>
> Tejesh R has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Updated based on review comments
>  - Updated based on review comments

test/jdk/javax/swing/DebugGraphics/DebugGraphicsNPETest.java line 37:

> 35: public class DebugGraphicsNPETest {
> 36:     public static void main(String[] args) throws Exception {
> 37:         SwingUtilities.invokeAndWait(new Runnable() {

No need of using EDT here as no Swing components in used. You can just move runTest() lines in main..

-------------

PR: https://git.openjdk.org/jdk/pull/9673



More information about the client-libs-dev mailing list