RFR: 8291959: FileFontStrike#initNative does not properly initialize IG Table on Windows [v2]
Julian Waters
jwaters at openjdk.org
Mon Aug 8 05:40:01 UTC 2022
> FileFontStrike#initNative calls memset with LCDLUTCOUNT (the maximum length) as the number of bytes to zero out, which is incorrect as the elements are not 1 byte in size (unsigned char*), and will result in only part of the IG Table being correctly zeroed. This is more correctly resolved by passing sizeof igLUTable to memset instead.
Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Merge branch 'openjdk:master' into patch-5
- Pass proper byte size to memset
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/9772/files
- new: https://git.openjdk.org/jdk/pull/9772/files/4a074c93..0d484cde
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=9772&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=9772&range=00-01
Stats: 735 lines in 31 files changed: 572 ins; 37 del; 126 mod
Patch: https://git.openjdk.org/jdk/pull/9772.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9772/head:pull/9772
PR: https://git.openjdk.org/jdk/pull/9772
More information about the client-libs-dev
mailing list