RFR: 6521141: DebugGraphics NPE @ setFont(); [v9]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Mon Aug 8 12:09:06 UTC 2022
On Fri, 5 Aug 2022 11:35:54 GMT, Tejesh R <tr at openjdk.org> wrote:
>> `DebugGraphics` class has a Graphics instance which is been used in slowed down drawing. The `graphics` object is not initialized anywhere inside the class, where it is expected to set explicitly by the user. When the user doesn't set it and try to use the any mehtods like `drawing/setFont`, NPE is raised which is expected. The scenario is taken care by checking if the `graphics` object is null before using it inside the class, thus eliminating the NPE case.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>
> Updated based on review comments
src/java.desktop/share/classes/javax/swing/DebugGraphics.java line 89:
> 87:
> 88: // Creates a Graphics context when the constructor is called.
> 89: if (graphics == null) {
Probably it will be better to use `this.graphics` here and below while setting.
-------------
PR: https://git.openjdk.org/jdk/pull/9673
More information about the client-libs-dev
mailing list