RFR: 8292062: misc javax/swing tests failing

Phil Race prr at openjdk.org
Tue Aug 9 19:25:46 UTC 2022


On Tue, 9 Aug 2022 11:49:22 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> In [PR#9488](https://github.com/openjdk/jdk/pull/9488) https://git.openjdk.org/jdk/commit/b2f0cbdca109507e5f8e0c185f601c0c1e31f4fb
> `CTRL+ALT` mnemonic support was added for Nimbus in macOS instead of `Alt`
> 
> so 2 of the 3 tests were failing after that, as it has workaround for non-support of CTRL+ALT mnemonic in macos for Nimbus L&F.
> That workaround is now removed for the tests to now pass.
> 
> For RightAltKey test failure, we should have ALT_GRAPH mask for Menu.shortcutKeys also,
>  as it is done for
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java#L1101
> 
> so ALT_GRAPH support was added for Nimbus Menu.shortcutKeys

OK approved based on fuller test results

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9808



More information about the client-libs-dev mailing list