RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v7]

Harshitha Onkar honkar at openjdk.org
Thu Aug 11 22:27:47 UTC 2022


On Thu, 11 Aug 2022 20:36:48 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   helper method added to sync location
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 313:
> 
>> 311:             syncLocationToWindowManager();
>> 312:             if (testWindow != null) {
>> 313:                 testWindow.setLocation(frame.getX(),
> 
> Just a thought: Should the window be centered to the instruction frame rather left-aligned?
> 
> Left-aligned is simpler, it could be easier to scan too.

I think left-aligned is simpler :)
Centering would complicate the code and might be an overkill in this context.

-------------

PR: https://git.openjdk.org/jdk/pull/9525



More information about the client-libs-dev mailing list