RFR: 8292314: WINAPI address used as conditional in libsplashscreen
Julian Waters
jwaters at openjdk.org
Sat Aug 13 06:17:43 UTC 2022
libsplashscreen uses the address of the WINAPI UpdateLayeredWindow in the condition of an if block, which will always evaluate to true since the address is never NULL. It is highly unlikely that this is intentional, and is either a harmless mistake that is ultimately optimized out during compilation at best, or an as of yet uncaught, but severe bug in the implementation that fails to call UpdateLayeredWindow at worst.
Note: As of now the change simply removes the reference, advice is appreciated if the commit is incorrect and the affected site is actually meant to be a call to UpdateLayeredWindow (as well as whatever parameters are required)
-------------
Commit messages:
- First try, remove memory address entirely
Changes: https://git.openjdk.org/jdk/pull/9866/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9866&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8292314
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/9866.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9866/head:pull/9866
PR: https://git.openjdk.org/jdk/pull/9866
More information about the client-libs-dev
mailing list