RFR: 8289616: Drop use of Thread.stop in AppContext

Phil Race prr at openjdk.org
Mon Aug 15 03:49:55 UTC 2022


On Sun, 14 Aug 2022 23:53:21 GMT, Iris Clark <iris at openjdk.org> wrote:

>> Thread.stop() and ThreadGroup.destroy() are called by sun.awt.AppContext.dispose()
>> 
>> These should no longer be called. Both are deprecated for removal.
>> ThreadGroup.destroy() does nothing. Thread.stop() throws UnsupportedOperationException
>> for virtual threads, and is expected to do so for all threads if it is not removed before then.
>> 
>> This fix stops calling these methods and prints a warning from dispose() to encourage
>> callers to move away from AppContext which itself will likely be removed in a future release
>> since the Webstart and Plugin scenarios that needed it are no longer supported.
>> Although most tests that use AppContext are now irrelevant only one test actually fails
>> and is removed  so we are doing the least here and the big job of completely getting rid of
>> AppContext is for another day.
>
> src/java.desktop/share/classes/sun/awt/AppContext.java line 406:
> 
>> 404:             Remove all uses of this internal class as soon as possible.
>> 405:             There is no replacement.
>> 406:             """);
> 
> Should some portion of this warning be included in an `@implNote` in this method's JavaDoc?

Since it is internal API I think that unnecessarily generous.
It shouldn't be called anyway.

-------------

PR: https://git.openjdk.org/jdk/pull/9863



More information about the client-libs-dev mailing list