RFR: JDK-8292276 : Missing color names in CSS. [v2]
ScientificWare
duke at openjdk.org
Mon Aug 15 17:49:32 UTC 2022
> This is referenced in Java Bug Database as
> - [JDK-8292276 : Missing color names in CSS](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276)
>
> This is tracked in JBS as
> - [JDK-8292276 : Missing color names in CSS](https://bugs.openjdk.java.net/browse/JDK-8292276)
>
> Adds missing color names, defined by CSS Level 4, in CSS.java :
> CSS Color Module Level 4
> W3C Candidate Recommendation Snapshot, 5 July 2022
> [7.1 Named Colors](https://www.w3.org/TR/css-color-4/#named-color)
>
> Designed from : [ScientificWare JDK-8292276 : Missing color names in CSS](https://github.com/scientificware/jdk/issues/12)
ScientificWare has updated the pull request incrementally with one additional commit since the last revision:
Adds to CSS.java the missing color names.
Adds to CSS.java, the missing color names defined by :
CSS Color Module Level 4
W3C Candidate Recommendation Snapshot, 5 July 2022
[7.1 Named Colors](https://www.w3.org/TR/css-color-4/#named-color)
- Updates, Copyright year.
- Adds relative imports.
- Replaces, if ... then ... else statements with TreeMap called "colorNamed".
Code is more readable and easy to maintain.
After tests, HashMap seems slower than TreeMap. Results are available at https://github.com/scientificware/jdk/issues/12#issuecomment-1213978168.
Warning : The Previous JDK CSS Orange Color is different from CSS Color Recommendation.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/9825/files
- new: https://git.openjdk.org/jdk/pull/9825/files/bbec633b..8592fe54
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=9825&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=9825&range=00-01
Stats: 456 lines in 1 file changed: 156 ins; 298 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/9825.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9825/head:pull/9825
PR: https://git.openjdk.org/jdk/pull/9825
More information about the client-libs-dev
mailing list