RFR: 8288882: JFileChooser - empty (0 bytes) file is displayed as 1 KB [v16]
Abhishek Kumar
duke at openjdk.org
Wed Aug 17 04:29:22 UTC 2022
On Wed, 10 Aug 2022 19:30:29 GMT, Phil Race <prr at openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> updated as per review comments
>
> To have all files 1->1000 bytes be 1.0kB and yet 1,100 -> 1,200 bytes be 1.1kB does seem anomalous
> from a precision perspective, since the major order of magnitude would seem to be more important to describe.
>
> Since we already aren't going to say "bytes" for those small files, then just getting that precision with
> the decimal point seems better - as well as being consistent !
@prrace
} else if (len < 1024L) {
...
} has been removed in previous commit.
So if listViewWindowsStyle is false then the next else if will be executed i.e. <100L.
-------------
PR: https://git.openjdk.org/jdk/pull/9327
More information about the client-libs-dev
mailing list