RFR: 8291792: DefaultStyledDocument.setCharacterAttribute accepts negative length [v3]
Tejesh R
tr at openjdk.org
Wed Aug 17 06:57:00 UTC 2022
> The Document for _DefaultStyledDocument.setCharacterAttribute_ states that the range of length accepted is `length - the length >= 0`, whereas in code the length check is done only for `length==0`. Meaning the control just returns if the `length` is 0. Since length is _int_ type and there is a possibility of negative length being set through the method, the code doesn't actually handles the negative length case. Hence to handle negative length, negative length check has been added along with 0 check. Its safe to check and return the control for `negative` length input. Test case to check the same is added.
Tejesh R has updated the pull request incrementally with two additional commits since the last revision:
- Merge branch 'branch_8291792' of github.com:TejeshR13/jdk into branch_8291792
- Moved test to test/jdk/javax/swing/DefaultStyledDocument
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/9830/files
- new: https://git.openjdk.org/jdk/pull/9830/files/68a4b08f..3cbc7c51
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=9830&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=9830&range=01-02
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/9830.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9830/head:pull/9830
PR: https://git.openjdk.org/jdk/pull/9830
More information about the client-libs-dev
mailing list