RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v4]
Harshitha Onkar
honkar at openjdk.org
Thu Aug 18 23:03:34 UTC 2022
On Mon, 15 Aug 2022 18:39:21 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
> As suggested, further changes to PassFailJFrame (creating a new version) will be dealt as a separate issue after evaluating impact of redesigning the framework.
This will be taken up as a separate task and does not affect the present PR.
Following are proposed redesign changes to PassFailJFrame test framework.
1. Addition of JSplitPane – for instruction and test window
2. If an exception is thrown before awaitAndCheck is called, the test will hang eventually. Clicking the Pass/Fail buttons doesn't close the UI since it's inside awaitAndCheck. This needs to be addressed when redesigning the framework.
3. Functional Style Paradigm: so that the code to create the test UI (window or component) can be passed as a method reference to constructor.
4. Handler for the close button on test UI windows / frames (obtained via a factory method which would fail the test and dispose the UI). Currently it's to be handled by each test (usually remain unhandled).
5. Better formatting option for instruction window – support for html tags.
The plan is to start the changes as a new and separate test framework to minimize the impact on existing manual test cases using PassFailJFrame. If anyone has anything additional, please feel free to add or provide feedback on this discussion.
-------------
PR: https://git.openjdk.org/jdk/pull/9525
More information about the client-libs-dev
mailing list