RFR: 8292304: [REDO] JDK-8289208 Test DrawRotatedStringUsingRotatedFont.java occasionally crashes on MacOS

Phil Race prr at openjdk.org
Fri Aug 19 16:49:17 UTC 2022


On Tue, 16 Aug 2022 08:26:08 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:

> See also the [original pull request](https://github.com/openjdk/jdk/pull/9362) where the change is explained and discussed in details.
> 
> Compared to the original version of this fix I
> * changed the error reporting from `printStackTrace()` to `System.out.println()` as per @prrace request,
> * fixed the test to use `AtomicInteger` for the counter of disposer records as `+=` and `--` operations on a `volatile int` do not guarantee value's integrity, which caused the test to often fail.
> 
> `test/jdk/sun/java2d/Disposer/TestDisposerRace.java` now passes successfully on MacOS and Linux.

I ran this and the new tests with all our other tests and the job passed so this looks fine now.
Still, I suggest to wait for Monday before pushing :-)

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9890



More information about the client-libs-dev mailing list