RFR: 7175397: The divider color is not changed to green when dragging for Nimbus LaF.

Phil Race prr at openjdk.org
Sun Aug 21 21:26:31 UTC 2022


On Fri, 19 Aug 2022 07:40:13 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> SplitPaneDivider.draggingColor UIProperty was not honoured in Nimbus L&F. 
> Added support for setting SplitPane dragging color for Nimbus L&F by drawing a fillRect of the set color as done in BasicLookAndFeel.
> The fix relies on `continuousLayout` property being false by default which is enabled for Nimbus, which is set to default false now, same as in other L&F. I think it was set true just to have documented default value in JDK-6937415
> 
> closed test mentioned in JBS is used for fix check.
> All jtreg swing tests are ok along with SwingSet2 JSplitPane demo in Nimbus L&F.

src/java.desktop/share/classes/javax/swing/plaf/nimbus/skin.laf line 21333:


You wrote

The fix relies on continuousLayout property being false by default which is enabled for Nimbus, which is set to default false now, same as in other L&F. I think it was set true just to have documented default value in JDK-6937415


I don't think so .. it was documenting the Nimbus default which is continuous.
Per the javadoc for 
https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JSplitPane.html#setContinuousLayout(boolean)

" The default value of this property is look and feel dependent."

So if Nimbus has had it ON all this time, it is not right to change it.

-------------

PR: https://git.openjdk.org/jdk/pull/9937



More information about the client-libs-dev mailing list