RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v9]

Harshitha Onkar honkar at openjdk.org
Mon Aug 22 18:05:41 UTC 2022


> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds of test instruction frame are added to PassFailJFrame to handle positioning of multiple test frames.
> 
> In scenarios where multiple test windows might be present, the test windows might overlap the instruction frame. In order to fix this TOP_LEFT_CORNER position option is added that positions the test instruction frame at top left corner with main test window below it.
> 
> Additionally `getInstructionFrameBounds()` is added to obtain the position and dimensions of test instruction frame.

Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - Merge branch 'master' into ManualTestsGH_8289075
 - review changes
 - helper method added to sync location
 - added null check in positionWindow
 - added Thread.sleep and changed the location of setVisible
 - added screen insets to account for taskbar position, doc changes
 - window positioning changes
 - Top left positon added
 - PassFailJFrame changes for multiple frame scenarios

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9525/files
  - new: https://git.openjdk.org/jdk/pull/9525/files/0567db94..9678450a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9525&range=08
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9525&range=07-08

  Stats: 76050 lines in 1646 files changed: 38587 ins; 30132 del; 7331 mod
  Patch: https://git.openjdk.org/jdk/pull/9525.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9525/head:pull/9525

PR: https://git.openjdk.org/jdk/pull/9525



More information about the client-libs-dev mailing list