RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v8]

[Harshitha Onkar]

On Sun, 21 Aug 2022 21:52:21 GMT, Phil Race <prr at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review changes
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 269:
> 
>> 267:      * parameter.
>> 268:      * Note: This method should be invoked from the method that creates
>> 269:      * testWindow. At test-level, the testWindow must be made visible
> 
> I think we should remove that Note sentence - surely the calling method is irrelevant. 
>  It is sufficient to explain that 
> "This method should be called before making the test window visible".
> But why is that ?

@prrace If the testWindow is made visible before calling `positionTestWindow()`, it is seen in the previous location for a short duration before being moved to the final location. Visually, the swap from previous to new location was visible. To avoid this, `testWindow.setVisible()` needs to called after `positionTestWindow()`. https://github.com/openjdk/jdk/pull/9525#issuecomment-1205915695

-------------

PR: https://git.openjdk.org/jdk/pull/9525