RFR: JDK-8292276 : Missing color names in CSS. [v6]

ScientificWare duke at openjdk.org
Mon Aug 22 21:21:31 UTC 2022


On Mon, 22 Aug 2022 00:57:28 GMT, SWinxy <duke at openjdk.org> wrote:

>> ScientificWare has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removes whitespace.
>>   
>>   Remove a whitespace at the end of the file
>
> I mean I think I would *prefer* the switch over a map (it looks nicer to me). My crude tests showed that the switch is indeed slower, breaking my conception that switch statements are the peak of performance. Other than [this request](#issuecomment-1216011827), I have no further comments.

@SWinxy Thanks for your reviews and confirmation tests.
Do you notice that the `switch ... case` is also two times slower than my "handmade" binary tree using `if ... else` !  A problem in the implementation of  'switch ... case' ?

-------------

PR: https://git.openjdk.org/jdk/pull/9825



More information about the client-libs-dev mailing list