RFR: JDK-8290469: Add new positioning options to PassFailJFrame test framework [v12]

Alexey Ivanov aivanov at openjdk.org
Tue Aug 23 18:50:55 UTC 2022


On Tue, 23 Aug 2022 18:25:03 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Additional position setting (TOP_LEFT_CORNER) and a method to obtain bounds of test instruction frame are added to PassFailJFrame to handle positioning of multiple test frames.
>> 
>> In scenarios where multiple test windows might be present, the test windows might overlap the instruction frame. In order to fix this TOP_LEFT_CORNER position option is added that positions the test instruction frame at top left corner with main test window below it.
>> 
>> Additionally `getInstructionFrameBounds()` is added to obtain the position and dimensions of test instruction frame.
>
> Harshitha Onkar has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Updated javadoc as per the review comments
>    
>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>
>  - Updated javadoc as per the review comments
>    
>    Co-authored-by: Alexey Ivanov <70774172+aivanov-jdk at users.noreply.github.com>

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 332:

> 330:     /**
> 331:      * To ensure the frame location is updated by the window manager
> 332:      * if it adjusts the frame location after {@code setLocation}

Suggestion:

     * Ensures the frame location is updated by the window manager
     * if it adjusts the frame location after {@code setLocation}


For consistent documentation where method descriptions start with a verb.

-------------

PR: https://git.openjdk.org/jdk/pull/9525



More information about the client-libs-dev mailing list