RFR: 8292848: AWT_Mixing and TrayIcon tests fail on el8 with hard-coded isOel7
Phil Race
prr at openjdk.org
Thu Aug 25 18:59:10 UTC 2022
On Wed, 24 Aug 2022 07:06:15 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:
> Could you please review the JDK-8292848 bug fixes?
> The purpose of the isOel7 method is to detect differences in GNOME version changes, and the isOel7
> result should be true after version 8.
> I modified the isOel7 method to use regular expressions instead of hard-coded versions to be able to
> detect the new os version.
> I also changed the method name to match the new conditions.
I guess this will do what was previously being done on OL7 .. but the way it is done it is fragile
and surely it can't be specific to OL .. and there's some pretty hokey adjustments going on in some of these tests.
I think some day these tests will need to be re-examined.
-------------
Marked as reviewed by prr (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9995
More information about the client-libs-dev
mailing list