RFR: 8297489: Modify TextAreaTextEventTest.java as to verify the content change of TextComponent sends TextEvent [v6]

Alexey Ivanov aivanov at openjdk.org
Thu Dec 1 15:21:26 UTC 2022


On Thu, 1 Dec 2022 14:50:31 GMT, ravi gupta <duke at openjdk.org> wrote:

>> Modify TextAreaTextEventTest.java as to verify the content changes of a both TextComponent(TextField,TextArea) for the following assertions.
>> 
>> a. TextListener get invoked when the content of a TextField gets changed.
>> b. TextListener not get invoked during text selection or when Special keys such as Function Keys are pressed.
>> 
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in macos,linux and windows and got all pass.
>
> ravi gupta has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review Comments Fixes

Marked as reviewed by aivanov (Reviewer).

test/jdk/java/awt/event/ComponentEvent/TextComponentTextEventTest.java line 113:

> 111:                 if (textComp instanceof TextField && textChanged) {
> 112:                     throw new RuntimeException(
> 113:                         "FAIL: TextEvent triggered when Enter pressed on "+ textComp);

Suggestion:

                        "FAIL: TextEvent triggered when Enter pressed on " + textComp);

-------------

PR: https://git.openjdk.org/jdk/pull/11326



More information about the client-libs-dev mailing list