RFR: 8296198: JFileChooser throws InternalError java.lang.InternalError with Windows shortcuts

[Abhishek Kumar]

On Mon, 5 Dec 2022 11:35:11 GMT, Tejesh R <tr at openjdk.org> wrote:

> When `JFileChooser` uses custom `FileSystemView`, traversing to link/shortcut to a folder throw `InternalError java.lang.InternalError ` in Windows. The issue found out to be in BasicFileChooserUI class which was unable to resolve the link path during directory setting. The `UsesShellFolder` check expects the FileSystemView to be of WindowsFileSystemView, which fails when custom FileSystemView is used.
> The fix includes resolving the link folder when custom File System View is used and has manual test. (Fix is test in CI system and no regression caused).

test/jdk/javax/swing/JFileChooser/FileSystemView/CustomFSVLinkTest.java line 131:

> 129:                 @Override
> 130:                 public Icon getSystemIcon(File f, int width, int height) {
> 131:                     return delegate.getSystemIcon(f, width, height);

Commented block of code can be removed.

-------------

PR: https://git.openjdk.org/jdk/pull/11510