RFR: JDK-8266245: AWT Test FullScreenInsets.java fails due to incorrect pixel color and wrong window bounds [v2]
Harshitha Onkar
honkar at openjdk.org
Tue Dec 6 19:03:18 UTC 2022
On Mon, 5 Dec 2022 22:10:15 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> The above test was failing due to incorrect pixel color and wrong window bounds on Mac-ARM, Windows and Linux platforms.
>>
>> The following changes have been made:
>> - Correct window bounds are obtained using the current ScreenDevice's DefaultConfig bounds (this test checks FullScreen functionality on multiple screen devices).
>> - Color tolerance has been added for color check
>> - Instead of scanning the full screen to check pixel color, vertical and horizontal scans are done at the far right and bottom end to ensure that window is in full screen mode w.r.t to screen device and the window bounds are as expected.
>>
>> CI testing passes on all platforms (tested 50 times per platform).
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> frame changed back to decorated and exclude on linux
@mrserb When scanning across the Buffered Image, the RGB obtained at certain locations returned 00fe00 instead of 00ff00 for Green and fe0000 instead of ff0000 for Red, hence a low color tolerance value was added.
The first 2 letters represents alpha channel followed by RGB
Log -
Actual: ff00fe00 ,expected : ff00ff00
Actual: fffe0000 ,expected : ffff0000
-------------
PR: https://git.openjdk.org/jdk/pull/11462
More information about the client-libs-dev
mailing list