RFR: 4668290: unclear spec for Polygon.bounds field [v3]

Alexey Ivanov aivanov at openjdk.org
Tue Dec 6 20:05:45 UTC 2022


On Fri, 30 Sep 2022 21:18:45 GMT, Phil Race <prr at openjdk.org> wrote:

>> SWinxy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use javadoc code syntax for null
>
> src/java.desktop/share/classes/java/awt/Polygon.java line 111:
> 
>> 109:      * {@link #getBounds()} called with {@link #npoints} being greater than
>> 110:      * {@code 0} will transfer into a non-null {@link Rectangle}.
>> 111:      *
> 
> Another dubious piece of design. This should never have been exposed in the API.
> What we need to say here is
> /*
>  * The value of this field is updated by the implementation which may set it to null and will
>  *   re-evaluate it as needed. Application sub-classes should never access this field.
>  */
> And leave it at that.

I noticed one thing: Phil suggested “re-evaluate”, you used “reevaluate” without the hyphen.

I tend to use the hyphened version; at the same time, articles in the internet suggest the hyphen is unneeded in such words.

I'm fine with either.

-------------

PR: https://git.openjdk.org/jdk/pull/10417



More information about the client-libs-dev mailing list