RFR: 8165943: LineBreakMeasurer does not measure correctly if TextAttribute.TRACKING is set. [v3]

Olga Mikhaltsova omikhaltcova at openjdk.org
Tue Dec 6 21:33:10 UTC 2022


On Tue, 6 Dec 2022 21:21:59 GMT, Olga Mikhaltsova <omikhaltcova at openjdk.org> wrote:

>> This is a fix for LineBreakMeasurer. It takes into account the TextAttribute.TRACKING value (not eq 0) while calculating the line breaks.
>> 
>> Tested on Linux x64, Windows x64, macOS x64 with the reproducer (LineBreakSample.java) attached to JDK-8165943 and the following group of tests:
>> `$JTREG_HOME/bin/jtreg -jdk:$BUILD_HOME ./test/jdk/java/awt/font`
>
> Olga Mikhaltsova has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Added an automated test
>  - Fix for negative tracking and float
>  - Fix manual test

The following fixes are made:
- fixed the lines breaks calculation for the negative tracking values;
- included an epsilon for floating point operation;
- fixed the manual test according to the above comments;
- added a simple automated test similar to TestLineBreakWithFontSub.

-------------

PR: https://git.openjdk.org/jdk/pull/10289



More information about the client-libs-dev mailing list