RFR: 8244400: MenuItem may cache the size and did not update it when the screen DPI is changed
Sergey Bylokhov
serb at openjdk.org
Wed Dec 7 09:51:11 UTC 2022
On Wed, 7 Dec 2022 03:48:16 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> The MenuItemLayoutHelper.clearUsedParentClientProperties must be called automatically when the DPI was changed.
> Workaround added in the test for this bug is removed.
>
> CI tests are ok.
test/jdk/javax/swing/GraphicsConfigNotifier/StalePreferredSize.java line 2:
> 1: /*
> 2: * Copyright (c) 2018, 2020, Oracle and/or its affiliates. All rights reserved.
The date in the `BasicMenuItemUI.java` can be updated as well.
test/jdk/javax/swing/GraphicsConfigNotifier/StalePreferredSize.java line 99:
> 97: System.out.println("Skipped Motif");
> 98: continue;
> 99: }
You do not need to ignore it since it is still supported and seems to work.
test/jdk/javax/swing/GraphicsConfigNotifier/StalePreferredSize.java line 187:
> 185: if (component instanceof JMenuItem) {
> 186: // TODO JDK-8244400
> 187: MenuItemLayoutHelper.clearUsedParentClientProperties((JMenuItem)component);
This call was the only reason to have " * @modules java.desktop/sun.swing" at the header of the test.
-------------
PR: https://git.openjdk.org/jdk/pull/11551
More information about the client-libs-dev
mailing list