RFR: 8296198: JFileChooser throws InternalError java.lang.InternalError with Windows shortcuts [v3]
Tejesh R
tr at openjdk.org
Wed Dec 7 11:50:39 UTC 2022
> When `JFileChooser` uses custom `FileSystemView`, traversing to link/shortcut to a folder throw `InternalError java.lang.InternalError ` in Windows. The issue found out to be in BasicFileChooserUI class which was unable to resolve the link path during directory setting. The `UsesShellFolder` check expects the FileSystemView to be of WindowsFileSystemView, which fails when custom FileSystemView is used.
> The fix includes resolving the link folder when custom File System View is used and has manual test. (Fix is test in CI system and no regression caused).
Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
Updated based on review comments
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/11510/files
- new: https://git.openjdk.org/jdk/pull/11510/files/4dd8cc71..3bb397d5
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=11510&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=11510&range=01-02
Stats: 10 lines in 1 file changed: 4 ins; 5 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/11510.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11510/head:pull/11510
PR: https://git.openjdk.org/jdk/pull/11510
More information about the client-libs-dev
mailing list