Integrated: 8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working
Sergey Bylokhov
serb at openjdk.org
Thu Dec 8 23:31:53 UTC 2022
On Tue, 6 Dec 2022 09:18:21 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
> We have two types of properties in Swing, the "basics": were implemented a long time ago. Some of that properties are tested by the bug4314194 test. And other properties implemented as part of the Synth L&F, and based on it - Nimbus/GTK. Attempt to fix the issue reported by bug4314194 added support of two "basic" options to the Nimbus/GTK but at the same time broke the Synth/Nimbus properties. It is unclear what is the root cause and how these properties should work together(should they? I assume each "basic"/"synth" should support its own) I suggest to revert the changes in 20 to prevent the regression and rethink the solution later.
>
> In short, this is a request to revert the next fixes:
> * https://bugs.openjdk.org/browse/JDK-8075916 - for some reason broke the Synth/Nimbus properties
> * https://bugs.openjdk.org/browse/JDK-8295006 - This uses the same approach as the fix above
> The next two issues created to redo both:
> * https://bugs.openjdk.org/browse/JDK-8298149
> * https://bugs.openjdk.org/browse/JDK-8298153
This pull request has now been integrated.
Changeset: 5540a8c5
Author: Sergey Bylokhov <serb at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/5540a8c5b7160ab5c67bb84631e3de54fa5aeceb
Stats: 52 lines in 4 files changed: 18 ins; 21 del; 13 mod
8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working
Reviewed-by: psadhukhan
-------------
PR: https://git.openjdk.org/jdk/pull/11531
More information about the client-libs-dev
mailing list