RFR: 8296275: Write a test to verify setAccelerator method of JMenuItem [v6]
Naveen Narayanan
duke at openjdk.org
Mon Dec 12 14:58:57 UTC 2022
On Tue, 29 Nov 2022 16:08:26 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Naveen Narayanan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8296275: Review comments fixed.
>
> I have to repeat a more serious problem:
>
>> Since the test has nothing to do with `Desktop` class it should be moved to `JMenuItem` folder because it tests functionality of `JMenuItem`.
>
> If it's supposed to test the Swing support for macOS global, then the test should do it.
>
> Could you please clarify? If it's for regular `JMenu` and `JMenuItem`, move the test; if it's for the global, then modify the test accordingly.
@aivanov-jdk, @mrserb all review comments addressed.
-------------
PR: https://git.openjdk.org/jdk/pull/11035
More information about the client-libs-dev
mailing list