RFR: 8296275: Write a test to verify setAccelerator method of JMenuItem [v8]

[Alexey Ivanov]

On Fri, 9 Dec 2022 05:36:03 GMT, Naveen Narayanan <duke at openjdk.org> wrote:

>> This testcase will
>> 1) Verify setAccelerator method of JMenuitem.
>> 2) Check that the selection of a menu item in the menu bar will generate action by a key combination of META+M.
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in Mac OS, Linux and Windows and got all pass.
>
> Naveen Narayanan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8296275: Removing trailing whitespaces.

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JMenuItem/JMenuItemSetAcceleratorTest.java line 61:

> 59:         JMenuBar bar = new JMenuBar();
> 60:         JMenu menu = new JMenu("File Menu");
> 61:         JMenuItem menuItem = new JMenuItem("File Menu Item");

_File_ is much more standard than _File Menu_ unless you have a specific reason for a longer menu item.

test/jdk/javax/swing/JMenuItem/JMenuItemSetAcceleratorTest.java line 108:

> 106:             }
> 107:             System.out
> 108:                 .println("Test passed, received action event on menu item.");

Please, don't do it this way: it's better to wrap the `String` argument. We already [discussed it](https://github.com/openjdk/jdk/pull/11035#discussion_r1026888743).

If you want to strictly fit into 80-column limit, `"Test passed"` is enough for the message.

-------------

PR: https://git.openjdk.org/jdk/pull/11035