RFR: 4912623: GTK L&F: Folder list of the JFileChooser is allowing multiple selection unlike native

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Dec 13 14:52:57 UTC 2022


On Mon, 12 Dec 2022 05:56:38 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

> It is not possible to select all files on press of Ctrl+A in JFileChooser for GTK LAF where as all folders can be selected. 
> In native side on press of Ctrl+A, able to select all files as well as folders.
> 
> Proposed fix is to enable `multiselection `property by default for JFileChooser in GTK LAF to mimic native side behavior.
> 
> An automated test case is implemented and tested in CI. CI job links are attached in JBS.

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserCtrlASelection.java line 66:

> 64:             // Create a test directory that contains only folders
> 65:             testDir = new File(tmpDir, "testDir");
> 66:             if (!testDir.exists())

There should be braces here even for a single line as per coding convention...Also one more case down below..
please update before pushing..

-------------

PR: https://git.openjdk.org/jdk/pull/11627



More information about the client-libs-dev mailing list