RFR: 8296275: Write a test to verify setAccelerator method of JMenuItem [v8]

Naveen Narayanan duke at openjdk.org
Tue Dec 13 16:43:47 UTC 2022


On Mon, 12 Dec 2022 20:57:05 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Naveen Narayanan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8296275: Removing trailing whitespaces.
>
> test/jdk/javax/swing/JMenuItem/JMenuItemSetAcceleratorTest.java line 108:
> 
>> 106:             }
>> 107:             System.out
>> 108:                 .println("Test passed, received action event on menu item.");
> 
> Please, don't do it this way: it's better to wrap the `String` argument. We already [discussed it](https://github.com/openjdk/jdk/pull/11035#discussion_r1026888743).
> 
> If you want to strictly fit into 80-column limit, `"Test passed"` is enough for the message.

My IDE’s formatter auto wraps this line for 80 chars.
After every code change & formatting, I have to manually unwrap these lines.
There are 3 lines to  unwrap manually.

-------------

PR: https://git.openjdk.org/jdk/pull/11035



More information about the client-libs-dev mailing list