RFR: 8218474: JComboBox display issue with GTKLookAndFeel
Abhishek Kumar
abhiscxk at openjdk.org
Wed Dec 14 05:05:21 UTC 2022
On Wed, 7 Dec 2022 22:00:00 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> In case of GTK LAF, the current selected element was not visible due to arrowbutton is rendered in entire display area of Combobox.
>>
>> The proposed fix is to set the `squareButton `property of combobox to `false `so that the arrowbutton didn't take entire combobox display area for rendering. The `getMinimumSize `method is overridden in `SynthComboBoxUI `to consider **arrowbutton insets** for combobox minimum size.
>>
>> The JCK tests mentioned in JBS seems fine with the fix.
>> An automated test case is implemented to test in Nimbus and GTK LAF. The text color check is to ensure the current selected item is visible.
>>
>> When swing tests are run with LAF set to Nimbus and GTK LAF, few test failures observed.
>>
>> Although CI jobs looks ok with tests run in their default set LAFs.
>>
>> `open/test/jdk/javax/swing/JComboBox/TestComboBoxHeight.java` test passes if run in GTK LAF with current fix.
>
> No it is confidential or something like that. Cannot open/view it.
@mrserb Please have a look.
-------------
PR: https://git.openjdk.org/jdk/pull/11555
More information about the client-libs-dev
mailing list