RFR: JDK-8298093: improve cleanup and error handling of awt_parseColorModel in awt_parseImage.c [v3]

Christoph Langer clanger at openjdk.org
Wed Dec 14 16:01:46 UTC 2022


On Wed, 7 Dec 2022 08:54:29 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> The cleanup and error handling in function awt_parseColorModel in awt_parseImage.c could be improved.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   small adjustment

Marked as reviewed by clanger (Reviewer).

src/java.desktop/share/native/libawt/awt/image/awt_parseImage.c line 457:

> 455:     int i;
> 456:     static jobject s_jdefCM = NULL;
> 457:     cmP->nBits = NULL;

I think you could leave the cmP->nBits initialization where it was. But that's just a nit.

-------------

PR: https://git.openjdk.org/jdk/pull/11508



More information about the client-libs-dev mailing list