[jdk20] RFR: 8298217: Regressions 30-110% in SwingMark on MacOS, more so on aarch64
Ajit Ghaisas
aghaisas at openjdk.org
Fri Dec 16 15:27:37 UTC 2022
The nature of data plays an important part in rendering performance as noted in the comment made on [JDK-8288948](https://bugs.openjdk.org/browse/JDK-8288948) -
https://bugs.openjdk.org/browse/JDK-8288948?focusedCommentId=14504772&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14504772
Although the fix [JDK-8288948](https://bugs.openjdk.org/browse/JDK-8288948) is logical, it seems to have an adverse impact on SwingMark test numbers especially on aarch64.
The SwingMark tests closely depict the UI operations in real-world applications as compared to the J2DBench and RenderPerfTest tests. Hence, it is decided to revert the regression causing commits [JDK-8288948](https://bugs.openjdk.org/browse/JDK-8288948) (and dependent [JDK-8291266](https://bugs.openjdk.org/browse/JDK-8291266)).
Metal rendering pipeline performance numbers before and after this PR are attached to the JBS.
Note : The fix for [JDK-8291266](https://bugs.openjdk.org/browse/JDK-8291266) has a good regression test - DrawPrimitivesTest.java. It passes even after reverting the said changes. This test will be added back once this PR is committed.
-------------
Commit messages:
- Revert JDK-8288948 Fix
- Revert JDK-8291266 Fix
Changes: https://git.openjdk.org/jdk20/pull/47/files
Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=47&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8298217
Stats: 410 lines in 5 files changed: 27 ins; 302 del; 81 mod
Patch: https://git.openjdk.org/jdk20/pull/47.diff
Fetch: git fetch https://git.openjdk.org/jdk20 pull/47/head:pull/47
PR: https://git.openjdk.org/jdk20/pull/47
More information about the client-libs-dev
mailing list