[jdk20] RFR: 4512626: Non-editable JTextArea provides no visual indication of keyboard focus [v2]

Alexander Zuev kizune at openjdk.org
Fri Dec 16 21:12:58 UTC 2022


On Thu, 15 Dec 2022 20:09:35 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed MultiSelectionText so it is now stable on Linux
>>   Removed both fixed tests from ProblemList
>
> src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java line 1050:
> 
>> 1048:                     flasher = new Timer(rate, handler);
>> 1049:                 }
>> 1050:                 flasher.setDelay(rate);
> 
> Coming back to negative rate, looks like this changes the previous behavior:
> 
> Before the fix it did throw IAE in all cases:
> 
> https://github.com/openjdk/jdk20/blob/ca39eb906692568347e7f264520593188f9276cf/src/java.desktop/share/classes/javax/swing/Timer.java#L397-L406
> 
> After the fix IAE is thrown only if component is editable<br>
> In case of non-editable and may throw it way later after `setEditable(true)` call and focus gain.

Fixed.

-------------

PR: https://git.openjdk.org/jdk20/pull/21



More information about the client-libs-dev mailing list