RFR: 8293862: javax/swing/JFileChooser/8046391/bug8046391.java failed with 'Cannot invoke "java.awt.Image.getWidth(java.awt.image.ImageObserver)" because "retVal" is null' [v2]

[Alexey Ivanov]

On Thu, 15 Dec 2022 04:54:47 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Observation found when JFileChooser is instantiated in WindowsLookAndFeel which invokes getSystemIcon() from WindowsFileChooserUI class. Could not find the exact root cause so predicting it to be an issue with icons not loaded where resolutionVariants map is empty in _public Image getResolutionVariant(double width, double height) _. Hence proposing a null check before accessing getWidth(). Fix is tested in CI system.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated fix

You may still add `assert` statements into `MultiResolutionIconImage` constructors which ensures `resolutionVariants` contains no `null` values.

src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line 1444:

> 1442:                 }
> 1443:             }
> 1444:             if ((retVal != null) && (retVal.getWidth(null) != w)) {

I believe this change is not needed.

-------------

Changes requested by aivanov (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11104