RFR: 8298887: On the latest macOS+XCode the Robot API may report wrong colors
Sergey Bylokhov
serb at openjdk.org
Tue Dec 20 05:59:41 UTC 2022
The new macOS SDK provided by XCode 14.2 changed this macro:
`# define kCGBitmapByteOrder32Host kCGBitmapByteOrder32Little`
to this constant
`static const CGBitmapInfo kCGBitmapByteOrder32Host = kCGBitmapByteOrder32Little;`
As a result, our native code started to redefine the macro value to "define kCGBitmapByteOrder32Host 0". I think that was added a long time ago for a PPC platform.
I have also changed the type of the color we pass to the java Robot, the java code expects the xrgb format(the alpha ignored), but we for some reason prepared pre-multiplied alpha.
Tested on macOS 12.6.1 and 13.0.1 using xcode 14.2 and xcode 12.5.1
-------------
Commit messages:
- update bugid
- rework the patch
- 8298887: On the latest macOS+XCode the Robot API may report wrong colors
Changes: https://git.openjdk.org/jdk/pull/11733/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11733&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8298887
Stats: 17 lines in 5 files changed: 0 ins; 12 del; 5 mod
Patch: https://git.openjdk.org/jdk/pull/11733.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11733/head:pull/11733
PR: https://git.openjdk.org/jdk/pull/11733
More information about the client-libs-dev
mailing list