[jdk20] RFR: 8299077: [REDO] JDK-4512626 Non-editable JTextArea provides no visual indication of keyboard focus [v2]

Sergey Bylokhov serb at openjdk.org
Fri Dec 23 23:05:51 UTC 2022


On Wed, 21 Dec 2022 19:40:09 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Slightly updated original fix - got rid of the extra flasher reset. Tests are fixed to be more stable and pass on the corresponding platforms.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Simplifying the two nested if conditions into one.

src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java line 373:

> 371:     // --- FocusListener methods --------------------------
> 372: 
> 373:     /**

I guess everybody noticed the specification of this method.
>This is implemented to set the caret to visible if the component is editable.

That should be updated? And overall it seems the whole behavior change required CSR.

-------------

PR: https://git.openjdk.org/jdk20/pull/68



More information about the client-libs-dev mailing list