RFR: 8280913: Create a regression test for JRootPane.setDefaultButton() method [v3]

Abdul Kolarkunnu akolarkunnu at openjdk.java.net
Thu Feb 3 09:54:15 UTC 2022


On Sun, 30 Jan 2022 06:30:43 GMT, Manukumar V S <mvs at openjdk.org> wrote:

>> This tests the behaviour of the method JRootPane.setDefaultButton() in different platforms with different LAFs.
>> As per the spec https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JRootPane.html#setDefaultButton(javax.swing.JButton), "The default button is the button which will be activated when a UI-defined activation event (typically the Enter key) occurs in the root pane regardless of whether or not the button has keyboard focus (unless there is another component within the root pane which consumes the activation event, such as a JTextPane). ".
>> 
>> This test is run multiple times in different platforms and got 100% success in mac and windows, linux.
>
> Manukumar V S has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8280913: Create a regression test for JRootPane.setDefaultButton() method

test/jdk/javax/swing/JRootPane/DefaultButtonTest.java line 43:

> 41:     static volatile boolean buttonPressed = false;
> 42:     boolean testFailed = false;
> 43:     JButton button1;

button1, button2, panel & robot are used in single method, do they need to be class variables?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7278



More information about the client-libs-dev mailing list