RFR: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled [v4]
Phil Race
prr at openjdk.java.net
Mon Feb 7 03:45:16 UTC 2022
On Thu, 6 Jan 2022 02:49:17 GMT, Toshio Nakamura <tnakamura at openjdk.org> wrote:
>> Hi,
>>
>> Could you review the fix?
>> When non-English characters were printed from JTable on MacOS, CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However, CTextPipe seems not support glyph with slot number of composite fonts.
>>
>> The slot data mask of GlyphVector is 0xff000000. In my environment, Japanese font was loaded at slot 4, and glyph data is like [0x40003e5]. Then, unexpected glyph was drawn.
>
> Toshio Nakamura has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>
> - Revised according to review comments
> - Merge branch 'master' into 8240756
> - 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
> - revert previous proposal
> - Merge branch 'master' into 8240756
> - 2nd proposal
> - Revert previous change
> - Merge branch 'master' into 8240756
> merge master
> - 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
Ok. approved. An improvement but maybe there'll be some tweaks needed later.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3619
More information about the client-libs-dev
mailing list