RFR: 8281284 : Write JSlider accessibility test [v2]
Artem Semenov
asemenov at openjdk.java.net
Mon Feb 7 10:59:17 UTC 2022
On Fri, 4 Feb 2022 22:34:47 GMT, lawrence.andrews <duke at openjdk.java.net> wrote:
>> This testcase covers both old and new api ( api added in jdk17 getAccessibleAction(), getAccessibleActionCount() , getAccessibleActionDescription )
>>
>> @shurymury
>> @savoptik
>
> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
>
> Added @key headful
test/jdk/javax/accessibility/JSlider/JSliderAccessibilityTest.java line 1:
> 1: /*
Can you please tell me why you didn't place this test along the path:
test/jdk/java/awt/a11y
test/jdk/javax/accessibility/JSlider/JSliderAccessibilityTest.java line 47:
> 45: import javax.swing.SwingUtilities;
> 46:
> 47: public class JSliderAccessibilityTest {
You could place your test in this path:
test/jdk/java/awt/a11y
Then you can inherit it from AccessibleComponentTest, and then all accessibility tests will look the same.
test/jdk/javax/accessibility/JSlider/JSliderAccessibilityTest.java line 68:
> 66: frame.setLocationRelativeTo(null);
> 67: frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);
> 68: frame.setVisible(true);
Please add instructions to the test on how to take it on all intended platforms. And also when to consider that the test is passed correctly.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7355
More information about the client-libs-dev
mailing list