RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v3]
Alexey Ivanov
aivanov at openjdk.java.net
Wed Feb 9 08:56:05 UTC 2022
On Mon, 7 Feb 2022 18:29:47 GMT, lawrence.andrews <duke at openjdk.java.net> wrote:
>> 1) Removed =yesno that was causing the test to fail with following exception
>> test result: Error. Parse Exception: Arguments to `manual' option not supported: yesno
>> After removing =yesno, test was just passing without user interaction so fixed the following
>>
>> Add the following so that user can user interact with the test
>> a) Added pass/fail button and instruction for the user to know what he/she is going to test and what is expected.
>> b) Added Dialog with textarea to enter the reason for the testcase failure. This will help the user to understanding the reason why the test was failed while analyzing the results.
>>
>> @shurymury
>
> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
>
> Dispose the frame via EDT
test/jdk/java/awt/Graphics/TextAAHintsTest.java line 228:
> 226: mainThread = Thread.currentThread();
> 227: try {
> 228: mainThread.sleep(testTimeOut);
Suggestion:
Thread.sleep(testTimeOut);
`sleep` is a static method, it's better to call it via the class name rather than an instance variable. This will resolve the IDE warning.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7275
More information about the client-libs-dev
mailing list