RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS [v2]

[Phil Race]

On Tue, 1 Feb 2022 08:15:53 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> In JDK 9 the native code for the robot class was reworked to get an access to the HiDPI quality screenshots. So we allocate the data storage for the HiDPI quality and then request the best quality from the macOS.
>> 
>> It works fine if the user request the screenshot of some area, since we properly scale this area. Unfortunately it does not work well if the user request only one pixel, in this case we allocate the array of one element and does not multiply the size by the scale, so if the system scale is 2 then the macOS returns the 2x2 pixels, which does not fit properly to the array of one element. This can be checked by the Xcheck:jni option which produce fatal error in this case.
>> 
>> Solution is to allocate the storage of the proper size 1 * scale * 1 * scale
>
> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - the new check
>  - Merge branch 'master' into JDK-8274939
>  - Initial fix JDK-8274939

Sorry, missed this update.

-------------

Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5864